Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kubebuilder CRD workflow #376

Merged
merged 5 commits into from Jun 29, 2021
Merged

Use kubebuilder CRD workflow #376

merged 5 commits into from Jun 29, 2021

Conversation

jpellizzari
Copy link
Contributor

@jpellizzari jpellizzari commented Jun 22, 2021

Relies on #368
Adds a new Makefile job(s) to create the crd yaml from a Golang struct via kubebuilder.

The allows us to build out our CRD from a go struct and use the CR as an object throughout the code base.

@jpellizzari jpellizzari force-pushed the jp-new-crd-workflow branch 3 times, most recently from 0a560a8 to 2291f07 Compare June 23, 2021 15:59
@jpellizzari jpellizzari marked this pull request as ready for review June 23, 2021 16:04
@jpellizzari jpellizzari force-pushed the jp-new-crd-workflow branch 6 times, most recently from c7f2809 to 7d8ffab Compare June 29, 2021 17:46
Copy link
Contributor

@jrryjcksn jrryjcksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpellizzari jpellizzari merged commit 617f412 into main Jun 29, 2021
@jpellizzari jpellizzari deleted the jp-new-crd-workflow branch June 29, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants