Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose OSS static asset handling to unify OSS/EE serving #4007

Merged
merged 7 commits into from
Dec 4, 2023

Conversation

foot
Copy link
Contributor

@foot foot commented Sep 13, 2023

  • Asset handling is growing more logic like injecting tags
  • We should have the same code in OSS/EE

What changed?

Expose OSS static asset handling as exports

Why was this change made?

  • Asset handling is growing more logic like injecting tags
  • We should have the same code in OSS/EE

How was this change implemented?

Extracting some internal handlers etc

How did you validate the change?

  • unit tests
  • manual testing

Release notes

Documentation Changes

foot and others added 5 commits September 13, 2023 09:32
- Asset handling is growing more logic like injecting <base> tags
- We should have the same code in OSS/EE
@foot foot marked this pull request as ready for review December 4, 2023 12:46
@foot foot requested a review from AlinaGoaga December 4, 2023 12:47
Copy link
Contributor

@AlinaGoaga AlinaGoaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@foot foot merged commit 6cbe63a into main Dec 4, 2023
16 checks passed
@foot foot deleted the unify-ee-oss-asset-serving branch December 4, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants