Add k8s test isolation (via namespace) #429

jpellizzari · 2021-07-02T18:51:47Z

Adds test isolation for controller-runtime tests. This is based on the kustomization-controller tests: https://github.com/fluxcd/kustomize-controller/blob/main/controllers/kustomization_controller_test.go

Thanks to @stefanprodan and @stealthybox for the help ^^

Also requires a namespace for fetching applications.

bigkevmcd

Some nice work in here...mostly minor suggestions.

api/applications/applications.proto

pkg/kube/kube.go

pkg/kube/kube_suite_test.go

pkg/kube/kubehttp.go

pkg/kube/kubehttp_test.go

jpellizzari requested review from luizbafilho, bigkevmcd and J-Thompson12 July 2, 2021 18:51

jpellizzari force-pushed the jp-k8s-tests branch from c36f9ea to 5f8eba5 Compare July 2, 2021 18:56

bigkevmcd reviewed Jul 6, 2021

View reviewed changes

jpellizzari force-pushed the jp-k8s-tests branch 2 times, most recently from dcacd2a to 18ea661 Compare July 7, 2021 17:08

jpellizzari added 5 commits July 7, 2021 10:09

Add namespace to application requests

51285c2

Add testenv setup and isolation

da6e789

Change to name and namespace fields for application proto

d50a368

Use types.NamespacedName instead of double string args

9bc5aed

Make all error messages wrap errors

0c16854

jpellizzari force-pushed the jp-k8s-tests branch from 18ea661 to 0c16854 Compare July 7, 2021 17:09

luizbafilho approved these changes Jul 7, 2021

View reviewed changes

J-Thompson12 approved these changes Jul 7, 2021

View reviewed changes

jpellizzari merged commit 8f17947 into main Jul 7, 2021

jpellizzari deleted the jp-k8s-tests branch July 7, 2021 22:03

Provide feedback