Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for wego app add --chart #434

Merged
merged 24 commits into from
Jul 9, 2021
Merged

Conversation

rokshana-b
Copy link
Contributor

@rokshana-b rokshana-b commented Jul 6, 2021

Why?
Adding test cases for:

  • wego app status
  • wego app add -h
  • wego app status -h
  • wego app list -h
  • wego flux -v
  • wego quits if 'flux-system' namespace is present

Copy link
Contributor

@jrryjcksn jrryjcksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks okay to me but I'm concerned that the help tests are really brittle and are only helpful when someone inadvertently changes the output. Any legitimate change will break tests. Maybe we should consider storing the help strings in a separate file that we can pull in to both the command code and the tests. That way deliberate changes to the help text wouldn't break any tests. 🤔 Let's discuss this at the standup.

@jpellizzari
Copy link
Contributor

This all looks okay to me but I'm concerned that the help tests are really brittle and are only helpful when someone inadvertently changes the output. Any legitimate change will break tests. Maybe we should consider storing the help strings in a separate file that we can pull in to both the command code and the tests. That way deliberate changes to the help text wouldn't break any tests. Let's discuss this at the standup.

I was going to leave similar feedback, but I realized that this PR is following suit with way the prior tests were written. I have created this issue to track the conversation: #454

@rokshana-b rokshana-b merged commit 312cfe5 into main Jul 9, 2021
@rokshana-b rokshana-b deleted the test-app-config-url branch July 9, 2021 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants