Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving add command output #448

Merged
merged 5 commits into from
Jul 9, 2021
Merged

Improving add command output #448

merged 5 commits into from
Jul 9, 2021

Conversation

luizbafilho
Copy link
Contributor

What changed?

This is how it should look like now:

$ wego app add . --path ./kustomize --auto-merge=true
Adding application:

Name: podinfo
URL: ssh://git@github.com/luizbafilho/podinfo.git
Path: ./kustomize
Branch: main
Type: kustomize

◎ Checking cluster status
✔ Wego installed
✚ Generating Source manifest
✚ Generating GitOps automation manifests
✚ Generating Application spec manifest
► Writing manifests to disk
► Applying manifests to the cluster
► Commiting and pushing wego resources for application
► Pushing app manifests to repository

Why?

  • UX improvements

How did you test it?

Release notes

Documentation Changes

Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This highlights an issue of code sharing within the company (or lack thereof). I assume the reason the logger is copy/pasted from flux is to avoid breakages if they change something in their project.

This also means that we have duplicated code and tests, and improvements in one version won't be available in another.

Copy link
Contributor

@josecordaz josecordaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luizbafilho luizbafilho merged commit e723a39 into main Jul 9, 2021
@luizbafilho luizbafilho deleted the 356/logger branch July 9, 2021 13:36
@luizbafilho luizbafilho restored the 356/logger branch December 8, 2021 17:36
@bigkevmcd bigkevmcd deleted the 356/logger branch December 15, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve output of "wego app add"
3 participants