Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor add tests to reduce test runtime #479

Merged
merged 10 commits into from
Jul 15, 2021
Merged

Refactor add tests to reduce test runtime #479

merged 10 commits into from
Jul 15, 2021

Conversation

rokshana-b
Copy link
Contributor

What changed?

  • Added test case for --chart --app-config-url<url>
  • Added test case for wego app list
  • Removed redundant test cases from wego app add test file
  • Disabled help text tests for now

josecordaz
josecordaz approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@josecordaz josecordaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jrryjcksn
jrryjcksn approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@jrryjcksn jrryjcksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rokshana-b rokshana-b merged commit c827d7a into main Jul 15, 2021
@rokshana-b rokshana-b deleted the app-config-url-url-test branch July 15, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josecordaz josecordaz josecordaz approved these changes

@jrryjcksn jrryjcksn jrryjcksn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rokshana-b @josecordaz @jrryjcksn