Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix_indentation_issue #480

Merged
merged 1 commit into from
Jul 15, 2021
Merged

fix_indentation_issue #480

merged 1 commit into from
Jul 15, 2021

Conversation

D3nn
Copy link
Contributor

@D3nn D3nn commented Jul 15, 2021

What changed?
SilenceUsage and SilenceError were both incorrectly indent in the cmd/wego/app/status/cmd.go

Why?
General hygiene

How did you test it?
Compiled and validated use of the wego app status command (which worked previously despite the indentation issue)

Release notes
NO

Documentation Changes
NO

@D3nn D3nn self-assigned this Jul 15, 2021
@D3nn D3nn requested review from palemtnrider, jpellizzari and jrryjcksn and removed request for jpellizzari July 15, 2021 19:48
jrryjcksn
jrryjcksn approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@jrryjcksn jrryjcksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jpellizzari
jpellizzari approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe we can add a check to CI that if go fmt edits any files, it fails CI.

The issue with only some folks running formatters is that it dirties up the PRs when the next person comes along.

@D3nn D3nn linked an issue Jul 15, 2021 that may be closed by this pull request
Example for wego app add --help is out of date #295
Closed
@D3nn D3nn removed a link to an issue Jul 15, 2021
Example for wego app add --help is out of date #295
Closed
@D3nn D3nn linked an issue Jul 15, 2021 that may be closed by this pull request
Example for wego app add --help is out of date #295
Closed
@D3nn D3nn merged commit 3f35c81 into main Jul 15, 2021
@D3nn D3nn deleted the fix_indentation_issue branch July 15, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpellizzari jpellizzari jpellizzari approved these changes

@jrryjcksn jrryjcksn jrryjcksn approved these changes

@palemtnrider palemtnrider Awaiting requested review from palemtnrider

Assignees

@D3nn D3nn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example for wego app add --help is out of date
3 participants
@D3nn @jpellizzari @jrryjcksn