Add -B to "make dependencies" so the release process has a flux binary from which to get a version #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y from which to get a version
jpellizzari
approved these changes
Jul 19, 2021
jrryjcksn
deleted the
fix-release-process-now-that-dependencies-are-not-built-every-time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Now that we don't always download dependencies, the release process failed as it wasn't getting a flux binary from which to obtain a version. This adds the
-Bflag so that we always download.Why?
So releasing will work
How did you test it?
Built a release in a fork
Release notes
No
Documentation Changes
None.