Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wego pkg constants instead of redeclaring #520

Merged
merged 1 commit into from Jul 26, 2021
Merged

Conversation

jpellizzari
Copy link
Contributor

Closes #507

We were declaring SourceType and DeploymentType in both the wego package, as well as in the services/app package. This removes the services/app/ declarations in favor of the wego` ones.

@jpellizzari jpellizzari marked this pull request as ready for review July 26, 2021 15:57
Copy link
Contributor

@J-Thompson12 J-Thompson12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jrryjcksn jrryjcksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to clean this up!

@jpellizzari jpellizzari merged commit 7b9a078 into main Jul 26, 2021
@jpellizzari jpellizzari deleted the 507-type-constants branch July 26, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the DeploymentType and SourceType from application_types here instead of defining again
3 participants