Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "wego gitops uninstall" to run to completion even if original install failed #716

Merged
merged 3 commits into from Sep 3, 2021

Conversation

jrryjcksn
Copy link
Contributor

Closes: #677

What changed?
wego gitops uninstall used to check for a complete wego installation before continuing. This prevented removing a partial installation.

Why?
So a failed installation can be undone

How did you test it?
Unit and integration tests

Release notes
No

Documentation Changes
No

@jrryjcksn jrryjcksn self-assigned this Sep 3, 2021
Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only nits.

pkg/kube/kubehttp.go Outdated Show resolved Hide resolved
pkg/services/gitops/uninstall_test.go Show resolved Hide resolved
pkg/services/gitops/uninstall_test.go Outdated Show resolved Hide resolved
@jrryjcksn jrryjcksn force-pushed the 677-uninstall-fails-after-unsuccessful-installation branch from f9b41a3 to 4e9a481 Compare September 3, 2021 20:07
@jrryjcksn jrryjcksn merged commit 97d684d into main Sep 3, 2021
@jrryjcksn jrryjcksn deleted the 677-uninstall-fails-after-unsuccessful-installation branch September 3, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants