Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating style guide #966

Merged
merged 5 commits into from Nov 10, 2021
Merged

Creating style guide #966

merged 5 commits into from Nov 10, 2021

Conversation

luizbafilho
Copy link
Contributor

What changed?

  • it adds a style guide to the project

Why?

How did you test it?

Release notes

Documentation Changes

@luizbafilho luizbafilho marked this pull request as ready for review October 26, 2021 13:39
@luizbafilho luizbafilho added documentation Improvements or additions to documentation type/enhancement New feature or request exclude from release notes and removed type/enhancement New feature or request labels Oct 26, 2021
@luizbafilho luizbafilho changed the title Creating style guid Creating style guide Oct 26, 2021
@JamWils JamWils self-requested a review October 28, 2021 14:14
doc/style.md Outdated Show resolved Hide resolved
Co-authored-by: James Wilson <James.wilson@weave.works>
Copy link
Contributor

@JamWils JamWils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @luizbafilho!!!

@luizbafilho luizbafilho merged commit 1c1e2c0 into main Nov 10, 2021
@luizbafilho luizbafilho deleted the style-guide branch November 10, 2021 15:31
@luizbafilho luizbafilho restored the style-guide branch December 8, 2021 17:35
@ozamosi ozamosi deleted the style-guide branch May 12, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation exclude from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants