Allow adding a public gitlab project #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Thompson12
commented
Nov 1, 2021
J-Thompson12
force-pushed
the
gitlab-public
branch
from
7ffe1f9
to
35a1f02
Compare
added 2 commits
November 1, 2021 16:13
J-Thompson12
force-pushed
the
gitlab-public
branch
from
dc52ca0
to
652d17b
Compare
luizbafilho
approved these changes
Nov 3, 2021
joshri
pushed a commit
that referenced
this pull request
Nov 4, 2021
* Allow adding a public gitlab project * add acceptance test * fix acceptance test * this auto change * Update testsuite_common_test.go undo change * fix acceptance test * add public group * update test readme * Update testsuite_common_test.go * add test log * add missing variable Co-authored-by: Justin Thompson <justin@weave.works>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #937
What changed?
MakeRepoPublic was still hardcoded to github. This was missed when changing everything to be more dynamic
Why?
How did you test it?
added unit tests and acceptance tests around public repos
Release notes
Documentation Changes