Discovered peers persistence #2317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awh
force-pushed
the
issues/2187-persist-discovered-peers
branch
4 times, most recently
from
4289f79
to
c49c31e
Compare
Merged
|
Needs rebase |
bboreham
force-pushed
the
issues/2187-persist-discovered-peers
branch
from
c49c31e
to
9e7118c
Compare
|
Rebased. |
|
Closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #2305, which should be merged first. Only the last two commits in this PR are relevant.
Depends on weaveworks/mesh#46, which should also be merged first.
Fixes #2187.
There are some issues:
ConnectionMakerperiodically synchronises the set of targets tocm.directPeers+ the subset ofcm.peersto which it does not have connections, it was necessary to introduce a third data structure (cm.indirectPeers) to include discovered peers from a previous run in the synchronisation. Whereas previously we would stop trying to connect to 'indirect' peers if they had disappeared fromcm.peers, that is no longer the case after a resume;cm.indirectPeerscan accumulate garbage which is only collected byweave stop(Noteweave forgetdoes not help, because that only removes things fromcm.directPeers).