Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail if only half the system IDs are blank #2743

Merged
merged 1 commit into from Jan 23, 2017
Merged

Don't fail if only half the system IDs are blank #2743

merged 1 commit into from Jan 23, 2017

Conversation

bboreham
Copy link
Contributor

@bboreham bboreham commented Jan 19, 2017 •
edited

Fix a bug in #2711
The symptom, on Scaleway, is:

All system IDs are blank

@bboreham bboreham added this to the 1.9.0 milestone Jan 19, 2017
@marccarre marccarre self-assigned this Jan 23, 2017
@marccarre
Copy link
Contributor

LGTM:
We need at least one system ID (i.e. either uuid or machineid, or both) in order to be able to generate a unique hash in MACfromUUID, so getSystemUUID should only fail if both uuid and machineid couldn't be read from the system.

@marccarre marccarre merged commit dd715e1 into master Jan 23, 2017
@marccarre marccarre deleted the fix-uuid branch January 23, 2017 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marccarre marccarre

Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bboreham @marccarre