Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iptable rules generated for Ingress NetworkPolicy when both port and IP block specified #3654

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

kitt1987
Copy link
Contributor

Fix #3653

@murali-reddy
Copy link
Contributor

@kitt1987 thanks for the PR.

Since CI can not run from the branches on forked repo I pushed your branch to weave repo. CI seems to be failing in an unrelated test but what seems to be result of new test in this PR. Can you please add cleanup logic end of the test to delete pod and network policy?

@kitt1987
Copy link
Contributor Author

OK.
I've fixed it in the last commit.

@kitt1987
Copy link
Contributor Author

@murali-reddy
Could you plz help run the CI again? I don't know exactly why the netlify failed.

@murali-reddy
Copy link
Contributor

murali-reddy commented Jun 28, 2019

I rerun the CI. For some reason 602_proxy_docker_py_test.sh continues to fail. I will check again and revert back.

@kitt1987
Copy link
Contributor Author

Thanks

@KresoDenis
Copy link

Will this get into next release.

@bboreham
Copy link
Contributor

CI ran successfully at https://circleci.com/workflow-run/d066cfca-f297-4b11-86a3-0339a5424e36
I experimented with rebasing this against the 2.5 branch, but the unit test relies on other changes not on that branch.

@bboreham bboreham merged commit 7aa7e3c into weaveworks:master Aug 29, 2019
@bboreham bboreham added this to the 2.6 milestone Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingress NetworkPolicy accepts all traffic when specifying both IPBlock and port
4 participants