This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Bump Docker to 19.03.1, Kubernetes to 1.14.0 for smoke tests #3687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
VM creation seems to need an update: |
murali-reddy
force-pushed
the
docker-19-3
branch
7 times, most recently
from
c63c792
to
e1bf7e1
Compare
|
@bboreham I updated the PR. Now its down to 2 test failures https://circleci.com/gh/weaveworks/weave/13206
Looks like there is bug fixed in docker-py docker/docker-py#2216
looks like breaking change in docker API |
including changes to accommodate current get.docker.com script
Using code from https://github.com/bboreham/docker-py/tree/v1.9.0-prime Also change to using Python 3 since 2.x is EOL.
bboreham
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't get #3680 to fail on my local machine with Docker 19.03 so maybe this will help.
Should update Kubernetes and CNI versions for smoke tests too, but one thing at a time.