Change the dnsPolicy for the weave-net pods to ClusterFirstWithHostNet #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @sidharthsurana we are tidy up current manifests. Once #3660, #3674 merged will point you to the right manifest to update. |
|
Those PRs are merged now and the best manifest to alter is https://github.com/weaveworks/weave/blob/master/prog/weave-kube/weave-daemonset-k8s-1.9.yaml |
sidharthsurana
force-pushed
the
fix-dnspolicy
branch
from
b5f43a7
to
e90cbf2
Compare
|
@bboreham done. Thanks for the pointer. |
|
Do we actually attempt to resolve any cluster DNS addresses? |
No. At the moment no servie is refered through its DNS name. Its more of confromance to the prescribed value for pods running in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no explicit
dnsPolicyspecified, thus when the DaemonSet is deployed it gets theClusterFirstpolicy. However, since the pods run withhostNetwork: true, the pods get configured with the DNS coming from the host instead of k8s. This means the out of the box weave pod would not be able to resolve any k8s service FQDNs. The more appropriate dnsPolicy would beClusterFirstWithHostNetas that would ensure that the DNS resolution for any k8s services would be at least possible.