Randomise wait to reclaim IPs on node deletion, and fix flaky test 870 #3716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, each run gets the same random numbers so all nodes are racing to remove the deleted node.
So we know when it came in, also which node.
Otherwise we see all the node addresses in the middle of the log.
Now we have a callback when a node is removed, there should be no reason to wait 90 seconds. The reclaim does wait up to 5 seconds before starting, so allowing 10 seconds in the script should be sufficient.
bboreham
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3690 - we should shut down Kubernetes before deleting the node otherwise Weave Net can restart.
While debugging this I found a few other things wrong with the
kube-utilsprogram, notably that the randomised wait would always take 3.081 seconds so we got a thundering herd every time.And reduce the wait in the test script - now we have a callback when a node is removed and ipam broadcasts the reclaim, there should be no reason to wait 90 seconds.