NPC: avoid logging dropped packets that were not actually dropped #3852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we might log a blocked connection even though the packet was not dropped.
saada
approved these changes
Aug 27, 2020
|
Yes, instead of setting it true before attempting then setting it back to false on error, we just wait till both commands have succeeded before setting it true. The whole function has a lock on |
bboreham
changed the title
bboreham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move egress logging rule beside drop rule, otherwise we might log a blocked connection even though the packet was not dropped.
Noticed while investigating #3829