Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from recursive go test, as it cannot output a merged coverage profile. #505

Merged
merged 1 commit into from Apr 1, 2015

Conversation

tomwilkie
Copy link
Contributor

  • Update said profile to coveralls.io
  • Add badge to readme

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8f87dc2 on tomwilkie:coverage into * on zettio:master*.

@tomwilkie
Copy link
Contributor Author

PTAL

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 11c9ad4 on tomwilkie:coverage into * on zettio:master*.

rm $$dir/profile.tmp; \
fi \
done
go tool cover -html=profile.cov -o=coverage.html

This comment was marked as abuse.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ac88b38 on tomwilkie:coverage into * on zettio:master*.

@@ -61,7 +61,15 @@ $(DOCKER_DISTRIB):
curl -o $(DOCKER_DISTRIB) $(DOCKER_DISTRIB_URL)

tests:
go test -cover -tags netgo ./...
echo "mode: count" > profile.cov
for dir in $$(find . -type f -name '*_test.go' | xargs -n1 dirname | sort | uniq); do \

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

…ge profile. Update said profile to coveralls.io; add badge.
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d28d52d on tomwilkie:coverage into * on zettio:master*.

for dir in $$(find . -type f -name '*_test.go' | xargs -n1 dirname | sort | uniq); do \
go test -tags netgo -covermode=count -coverprofile=$$dir/profile.tmp $$dir; \
if [ -f $$dir/profile.tmp ]; then \
cat $$dir/profile.tmp | tail -n +2 >> profile.cov; \

This comment was marked as abuse.

rade added a commit that referenced this pull request Apr 1, 2015
Move away from recursive go test, as it cannot output a merged coverage profile.
@rade rade merged commit df7836d into weaveworks:master Apr 1, 2015
@rade rade removed the in progress label Apr 1, 2015
@rade rade modified the milestone: 0.10.0 Apr 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants