Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canonical sets #518

Merged
merged 3 commits into from Apr 6, 2015
Merged

Canonical sets #518

merged 3 commits into from Apr 6, 2015

Conversation

rade
Copy link
Member

@rade rade commented Apr 6, 2015

No description provided.

rade added 3 commits April 6, 2015 11:35
@rade
use map[...]struct{} for sets instead of map[...]bool
74b3f8d 
See https://groups.google.com/d/msg/golang-nuts/lb4xLHq7wug/MhrSLkyS4F8J

We don't really care about the performance aspect of this, but using
struct{}{} values is in some way canonical since it means the
representation carries no redundant information.
@rade
make PeerNameSet a more broadly used type
6db12d6
@rade
tired of typing "struct{}{}"
e8e9a43
@rade
Copy link
Member Author

rade commented Apr 6, 2015

@bboreham mind taking a quick look at this?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 35.12% when pulling e8e9a43 on rade:canonical_sets into 6f2f25a on zettio:master.

rade added a commit that referenced this pull request Apr 6, 2015
@rade
Merge pull request #518 from rade/canonical_sets
fe4d8b7 
canonical sets
@rade rade merged commit fe4d8b7 into weaveworks:master Apr 6, 2015
@rade rade removed the in progress label Apr 6, 2015
@rade
Copy link
Member Author

rade commented Apr 6, 2015

@bbohreham never mind, I've merged it. But you may want to take a look anyway, just FYI.

@rade rade modified the milestone: 0.10.0 Apr 18, 2015
@rade rade mentioned this pull request Apr 22, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rade @coveralls