-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ip netns exec
with nsenter
#580
Conversation
|
Abstracted out to a function.
Done.
I've smoke tested this on Ubuntu Precise 12.04/3.5.0-54-generic and it works (modulo #585 and |
# Set $LOCAL_IFNAME and $GUEST_IFNAME to suitable names for two ends | ||
# of a veth pair, specific to the container, and execute args $2 $3 ... | ||
# as a command. If an error is caused by container dying, swallow output | ||
# from error. |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Fixed |
Replace `ip netns exec` with `nsenter` Closes #458.
Fixes #458. All smoke tests pass (
400_weave_local_test.sh
necessitated updating the Vagrantfiles to Ubuntu 14.10) but nevertheless quite invasive - suggest merging after 0.10.0?