Fix all reports from go test -race in weavedns unit tests
#935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
linter is unhappy. |
|
@inercia aside from the linter issue, are you happy with the rest? |
| select { | ||
| case action := <-actionChan: | ||
| if action == nil { | ||
| c.listener.Shutdown() | ||
| c.running = false | ||
| return |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@rade I've added a couple of comments.... |
…avoid race-condition
The shuffleAnswers() call ends up acting on the same data, so it seems simplest to resolve ownership arguments by copying.
This avoids race-conditions in unit tests where the initialisation is on a different goroutine to the logging.
Specifically, move the part that blocks, and call that as necessary. This means Start() can run on the caller's goroutine and avoid race conditions.
|
I re-did the last commit with an |
|
Thanks, @bboreham, it looks great now! Everything looks good to me now. Please merge it if all tests pass... |
bboreham
added a commit
that referenced
this pull request
Jun 17, 2015
All unit and smoke tests passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most are artefacts of the test code, but having so many reports made it difficult to check for any real problems.
The only one which looks like a real problem is a34d2ec, though aa85e19 could conceivably result in a crash.