Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail if id is not a valid uui #62

Closed
Tracked by #97
samos123 opened this issue Feb 14, 2023 · 2 comments
Closed
Tracked by #97

fail if id is not a valid uui #62

samos123 opened this issue Feb 14, 2023 · 2 comments

Comments

@samos123
Copy link
Collaborator

currently there is seems to be a silent failure, instead an error message should be shown to the user that the specified ID is not a valid UUID
@trengrj trengrj mentioned this issue Aug 1, 2023
Open
7 tasks
DusanMilunovic added a commit to DusanMilunovic/spark-connector that referenced this issue Nov 27, 2023
@DusanMilunovic
Test case for invalid uuid as ID (weaviate#62)
7af3a1f
@DusanMilunovic
Copy link
Contributor

DusanMilunovic commented Nov 27, 2023 •
edited

Can't reproduce this. Here's a PR with a test case that shows that write fails if ID is an invalid UUID:
#111

@samos123 please check if I'm missing something.

antas-marcin pushed a commit that referenced this issue Dec 7, 2023
@DusanMilunovic
Test case for invalid uuid as ID (#62) (#111)
333cb45
@antas-marcin
Copy link
Contributor

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samos123 @antas-marcin @DusanMilunovic