Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support properties field in generative groupedResult field #342

Merged
merged 1 commit into from
May 25, 2023

Conversation

antas-marcin
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.01 ⚠️

Comparison is base (c1cfaff) 95.74% compared to head (4f7b869) 95.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
- Coverage   95.74%   95.73%   -0.01%     
==========================================
  Files          64       64              
  Lines        7798     7807       +9     
==========================================
+ Hits         7466     7474       +8     
- Misses        332      333       +1     
Impacted Files Coverage Δ
integration/test_graphql.py 91.53% <0.00%> (-2.17%) ⬇️
test/gql/test_get.py 100.00% <100.00%> (ø)
weaviate/gql/get.py 97.22% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@antas-marcin antas-marcin force-pushed the properties-field-for-groupedresult branch from 4f7b869 to a63adb1 Compare May 24, 2023 15:48
@antas-marcin antas-marcin merged commit d1d421f into main May 25, 2023
17 checks passed
@antas-marcin antas-marcin deleted the properties-field-for-groupedresult branch May 25, 2023 15:40
@dandv
Copy link
Contributor

dandv commented May 30, 2023

🥳 Was looking forward to this! Added client examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants