-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tenant as an optional param to batch.delete_objects #375
Conversation
Hi @ciprianaradulescu , thank you for your contribution! Could you add a test under integration/test_batch.py? You could just extend |
Hello @dirkkul , I've extended Thank you ! |
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
I agree with the CLA. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
==========================================
- Coverage 95.63% 95.43% -0.21%
==========================================
Files 64 64
Lines 7836 8165 +329
==========================================
+ Hits 7494 7792 +298
- Misses 342 373 +31
☔ View full report in Codecov by Sentry. |
Hi @ciprianaradulescu, thank you, test looks good! Could you let black run over your code? The contributing guide shows how to do it. I'll merge afterwards |
Yeah, sorry, missed that 😁 Should be fine now. |
Fix for #374