Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group_by parameter to bm25 and hybrid #978

Merged
merged 12 commits into from
May 3, 2024

Conversation

tsmith023
Copy link
Contributor

@tsmith023 tsmith023 commented Mar 25, 2024

@tsmith023 tsmith023 changed the title Add group_by parameter to bm25 and `hybrid Add group_by parameter to bm25 and hybrid Mar 25, 2024
@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@tsmith023 tsmith023 requested a review from dirkkul April 2, 2024 13:38
@tsmith023 tsmith023 marked this pull request as ready for review April 2, 2024 13:39
@tsmith023 tsmith023 requested a review from a team as a code owner April 2, 2024 13:39
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 58.44156% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 94.83%. Comparing base (339f7ad) to head (622da77).

Files Patch % Lines
integration/test_collection_openai.py 20.00% 20 Missing ⚠️
integration/test_collection.py 84.00% 4 Missing ⚠️
weaviate/collections/queries/bm25/generate.py 40.00% 3 Missing ⚠️
weaviate/collections/queries/hybrid/generate.py 40.00% 3 Missing ⚠️
weaviate/collections/queries/bm25/query.py 80.00% 1 Missing ⚠️
weaviate/collections/queries/hybrid/query.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           dev/1.25     #978      +/-   ##
============================================
- Coverage     95.00%   94.83%   -0.17%     
============================================
  Files           175      175              
  Lines         18022    18089      +67     
============================================
+ Hits          17122    17155      +33     
- Misses          900      934      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirkkul dirkkul force-pushed the add-groupby-to-bm25-and-hybrid branch from f4faec3 to 649e3de Compare May 2, 2024 17:38
@dirkkul dirkkul merged commit fbe286b into dev/1.25 May 3, 2024
43 checks passed
@dirkkul dirkkul deleted the add-groupby-to-bm25-and-hybrid branch May 3, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants