Skip to content

Commit

Permalink
test public update object method, improve var names
Browse files Browse the repository at this point in the history
  • Loading branch information
Parker Duckworth committed Mar 9, 2022
1 parent 0fbb1ca commit 09a7f17
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions usecases/objects/update_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (

func Test_UpdateAction(t *testing.T) {
var (
vectorRepo *fakeVectorRepo
db *fakeVectorRepo
vectorizer *fakeVectorizer
manager *Manager
extender *fakeExtender
Expand All @@ -44,7 +44,7 @@ func Test_UpdateAction(t *testing.T) {
}

reset := func() {
vectorRepo = &fakeVectorRepo{}
db = &fakeVectorRepo{}
schemaManager := &fakeSchemaManager{
GetSchemaResponse: schema,
}
Expand All @@ -59,7 +59,7 @@ func Test_UpdateAction(t *testing.T) {
vectorizer = &fakeVectorizer{}
vecProvider := &fakeVectorizerProvider{vectorizer}
manager = NewManager(locks, schemaManager, cfg, logger, authorizer,
vecProvider, vectorRepo, getFakeModulesProviderWithCustomExtenders(extender, projectorFake))
vecProvider, db, getFakeModulesProviderWithCustomExtenders(extender, projectorFake))
}

t.Run("ensure creation timestamp persists", func(t *testing.T) {
Expand All @@ -76,16 +76,16 @@ func Test_UpdateAction(t *testing.T) {
Created: beforeUpdate,
Updated: beforeUpdate,
}
vectorRepo.On("ObjectByID", id, mock.Anything, mock.Anything).Return(result, nil).Once()
vectorRepo.On("PutObject", mock.Anything, mock.Anything).Return(nil)
vectorizer.On("UpdateObject", mock.Anything).Return(vec, nil)
db.On("ObjectByID", id, mock.Anything, mock.Anything).Return(result, nil).Once()
vectorizer.On("UpdateObject", mock.Anything).Return(vec, nil).Once()
db.On("PutObject", mock.Anything, mock.Anything).Return(nil).Once()

payload := &models.Object{
Class: "ActionClass",
ID: id,
Properties: map[string]interface{}{"foo": "baz"},
}
res, err := manager.updateObjectToConnectorAndSchema(context.Background(), &models.Principal{}, id, payload)
res, err := manager.UpdateObject(context.Background(), &models.Principal{}, id, payload)
require.Nil(t, err)
expected := &models.Object{
Class: "ActionClass",
Expand Down

0 comments on commit 09a7f17

Please sign in to comment.