add more inverted config test cases

weaviate · Mar 21, 2022 · 7860f17 · 7860f17
1 parent e87604f
commit 7860f17
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/adapters/repos/db/inverted/config_test.go b/adapters/repos/db/inverted/config_test.go
@@ -57,17 +57,17 @@ func TestValidateConfig(t *testing.T) {
 		assert.EqualError(t, err, "BM25.b must be <= 0 and <= 1")
 	})
 
-	t.Run("invalid BM25.b", func(t *testing.T) {
+	t.Run("with valid config", func(t *testing.T) {
 		in := &models.InvertedIndexConfig{
 			CleanupIntervalSeconds: 1,
 			Bm25: &models.BM25Config{
 				K1: 1,
-				B:  1.001,
+				B:  0.1,
 			},
 		}
 
 		err := ValidateConfig(in)
-		assert.EqualError(t, err, "BM25.b must be <= 0 and <= 1")
+		assert.Nil(t, err)
 	})
 }
 

diff --git a/adapters/repos/db/inverted/config_update_test.go b/adapters/repos/db/inverted/config_update_test.go
@@ -41,4 +41,26 @@ func TestValidateUserConfigUpdate(t *testing.T) {
 		assert.Equal(t, validInitial.Bm25.K1, updated.Bm25.K1)
 		assert.Equal(t, validInitial.Bm25.B, updated.Bm25.B)
 	})
+
+	t.Run("with invalid cleanup interval", func(t *testing.T) {
+		updated := &models.InvertedIndexConfig{
+			CleanupIntervalSeconds: -1,
+		}
+
+		err := ValidateUserConfigUpdate(validInitial, updated)
+		require.EqualError(t, err, "cleanup interval seconds must be > 0")
+	})
+
+	t.Run("with invalid updated Bm25 config", func(t *testing.T) {
+		updated := &models.InvertedIndexConfig{
+			CleanupIntervalSeconds: 1,
+			Bm25: &models.BM25Config{
+				K1: 1.2,
+				B:  1.2,
+			},
+		}
+
+		err := ValidateUserConfigUpdate(validInitial, updated)
+		require.EqualError(t, err, "BM25.b must be <= 0 and <= 1")
+	})
 }