errgroup wait correction on idx add property

weaviate · Apr 25, 2024 · b246329 · b246329
1 parent df2a66f
commit b246329
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/adapters/repos/db/index.go b/adapters/repos/db/index.go
@@ -422,11 +422,12 @@ func (i *Index) addProperty(ctx context.Context, props ...*models.Property) erro
 
 	i.ForEachShard(func(key string, shard ShardLike) error {
 		shard.createPropertyIndex(ctx, eg, props...)
-		if err := eg.Wait(); err != nil {
-			return errors.Wrapf(err, "extend idx '%s' with properties '%v", i.ID(), props)
-		}
 		return nil
 	})
+
+	if err := eg.Wait(); err != nil {
+		return errors.Wrapf(err, "extend idx '%s' with properties '%v", i.ID(), props)
+	}
 	return nil
 }
 

diff --git a/adapters/repos/db/shard.go b/adapters/repos/db/shard.go
@@ -757,10 +757,6 @@ func (s *Shard) createPropertyIndex(ctx context.Context, eg *enterrors.ErrorGrou
 
 			return nil
 		})
-
-		if err := eg.Wait(); err != nil {
-			return err
-		}
 	}
 	return nil
 }