Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-1837 WEAVIATE-2 fix segfault by copying memory #1843

Merged
merged 1 commit into from Mar 8, 2022

Conversation

etiennedi
Copy link
Member

This still requires a chaos-engineering pipeline to make sure this is
really fixed, so far manual testing seems to indicate that it is indeed
gone.

fixes #1837

This still requires a chaos-engineering pipeline to make sure this is
really fixed, so far manual testing seems to indicate that it is indeed
gone.
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #1843 (9280066) into master (4e1b648) will increase coverage by 0.05%.
The diff coverage is 67.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1843      +/-   ##
==========================================
+ Coverage   65.93%   65.98%   +0.05%     
==========================================
  Files         411      411              
  Lines       30884    30888       +4     
==========================================
+ Hits        20362    20382      +20     
+ Misses       8739     8716      -23     
- Partials     1783     1790       +7     
Flag Coverage Δ
integration 67.23% <50.00%> (+0.12%) ⬆️
unittests 65.98% <67.85%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ters/handlers/graphql/local/common_filters/bm25.go 0.00% <ø> (ø)
adapters/handlers/rest/middlewares.go 0.00% <0.00%> (ø)
adapters/repos/db/buffered_random_reader.go 70.83% <ø> (ø)
adapters/repos/db/inverted/bm25_searcher.go 0.00% <ø> (ø)
adapters/repos/db/inverted/prop_length_tracker.go 81.33% <ø> (ø)
adapters/repos/db/inverted/score_merger.go 100.00% <ø> (ø)
adapters/repos/db/inverted/stopwords/detector.go 40.74% <ø> (ø)
adapters/repos/db/lsmkv/binary_search_tree_map.go 97.29% <ø> (ø)
...os/db/lsmkv/segment_key_and_tombstone_extractor.go 84.37% <ø> (ø)
adapters/repos/db/lsmkv/strategies_map.go 56.87% <ø> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc50214...9280066. Read the comment docs.

@etiennedi etiennedi merged commit 8182935 into master Mar 8, 2022
@etiennedi etiennedi deleted the gh-1837-fix-segfault branch March 8, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: SEGFAULT when querying while importing
2 participants