Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-1836 Delete using filter leaves objects searchable #1845

Merged

Conversation

antas-marcin
Copy link
Contributor

Closes #1836

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #1845 (a061cc0) into master (9280066) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1845      +/-   ##
==========================================
- Coverage   65.98%   65.98%   -0.01%     
==========================================
  Files         411      411              
  Lines       30888    30895       +7     
==========================================
+ Hits        20382    20386       +4     
  Misses       8716     8716              
- Partials     1790     1793       +3     
Flag Coverage Δ
integration 67.24% <ø> (+<0.01%) ⬆️
unittests 65.98% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
usecases/objects/delete.go 72.00% <66.66%> (+5.33%) ⬆️
adapters/repos/db/lsmkv/bucket.go 61.94% <0.00%> (-1.50%) ⬇️
usecases/traverser/grouper/merge_group.go 80.58% <0.00%> (-1.18%) ⬇️
usecases/sharding/state.go 66.01% <0.00%> (-0.98%) ⬇️
...pters/repos/db/vector/hnsw/neighbor_connections.go 63.56% <0.00%> (+3.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45d6462...a061cc0. Read the comment docs.

@etiennedi etiennedi merged commit bec1baa into master Mar 8, 2022
@etiennedi etiennedi deleted the gh-1836-Delete-using-filter-leaves-objects-searchable branch March 8, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete using filter leaves objects searchable
2 participants