Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-1848 Bug: HNSW index fails if initial insert has doc id > 24999 #1851

Conversation

antas-marcin
Copy link
Contributor

Closes #1848

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #1851 (7cf0d9f) into master (01a8262) will increase coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1851      +/-   ##
==========================================
+ Coverage   66.06%   66.10%   +0.03%     
==========================================
  Files         411      411              
  Lines       30915    30918       +3     
==========================================
+ Hits        20425    20439      +14     
+ Misses       8691     8680      -11     
  Partials     1799     1799              
Flag Coverage Δ
integration 67.36% <33.33%> (+0.09%) ⬆️
unittests 66.10% <33.33%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
adapters/repos/db/vector/hnsw/insert.go 74.02% <33.33%> (-1.65%) ⬇️
usecases/sharding/state.go 66.99% <0.00%> (+0.97%) ⬆️
adapters/repos/db/lsmkv/bucket.go 64.17% <0.00%> (+1.49%) ⬆️
adapters/repos/db/shard_write_batch_objects.go 77.27% <0.00%> (+1.51%) ⬆️
adapters/repos/db/vector/hnsw/maintainance.go 86.20% <0.00%> (+20.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 877688d...7cf0d9f. Read the comment docs.

@etiennedi etiennedi merged commit 4723e5f into master Mar 10, 2022
@etiennedi etiennedi deleted the gh-1848-Bug-HNSW-index-fails-if-initial-insert-has-doc-id-gt-24999 branch March 10, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: HNSW index fails if initial insert has doc id > 24999
2 participants