Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extend HTTP backup & restore endpoints to allow for custom compression configuration #3367

Merged
merged 2 commits into from
Jan 10, 2024
Merged

feat: extend HTTP backup & restore endpoints to allow for custom compression configuration #3367

merged 2 commits into from
Jan 10, 2024

Conversation

redouan-rhazouani
Copy link
Contributor

ingest compression parameters into the backup process

What's being changed:

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@redouan-rhazouani redouan-rhazouani changed the title Backup: extend HTTP endpoints to include compression parameters Extend HTTP backup endpoints to include compression parameters Aug 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 8, 2023 •
edited

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (b3bc458) 62.88% compared to head (324ff25) 64.05%.
Report is 6 commits behind head on master.

❗ Current head 324ff25 differs from pull request most recent head 19ef8b8. Consider uploading reports for the commit 19ef8b8 to get more accurate results

Files Patch % Lines
adapters/handlers/rest/handlers_backup.go 0.00% 19 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3367      +/-   ##
==========================================
+ Coverage   62.88%   64.05%   +1.16%     
==========================================
  Files         820      711     -109     
  Lines       85582    74657   -10925     
==========================================
- Hits        53818    47818    -6000     
+ Misses      28271    23873    -4398     
+ Partials     3493     2966     -527

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@redouan-rhazouani redouan-rhazouani marked this pull request as ready for review August 8, 2023 20:26
@redouan-rhazouani redouan-rhazouani changed the title Extend HTTP backup endpoints to include compression parameters Extend HTTP backup endpoints to allow for custom compression configuration Aug 8, 2023
aliszka
aliszka previously approved these changes Aug 23, 2023
View reviewed changes
usecases/backup/handler.go Outdated Show resolved Hide resolved
usecases/backup/backend.go Outdated Show resolved Hide resolved
@moogacs moogacs force-pushed the feature/backup_compression_server_endpoint branch 2 times, most recently from 9e07e8e to 927a790 Compare January 4, 2024 16:12
@moogacs moogacs changed the title Extend HTTP backup endpoints to allow for custom compression configuration feat: extend HTTP backup endpoints to allow for custom compression configuration Jan 4, 2024
parkerduckworth
parkerduckworth reviewed Jan 4, 2024
View reviewed changes
Copy link
Member

@parkerduckworth parkerduckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice. Would probably be a good idea to add (or refactor) an acceptance for this feature.

@moogacs moogacs force-pushed the feature/backup_compression_server_endpoint branch 3 times, most recently from d92b6ee to 5836893 Compare January 7, 2024 13:37
@moogacs moogacs force-pushed the feature/backup_compression_server_endpoint branch 2 times, most recently from be35fef to c8ce94c Compare January 9, 2024 12:49
@moogacs moogacs force-pushed the feature/backup_compression_server_endpoint branch from c8ce94c to 3cf2a27 Compare January 9, 2024 12:58
@moogacs moogacs changed the title feat: extend HTTP backup endpoints to allow for custom compression configuration feat: extend HTTP backup & restore endpoints to allow for custom compression configuration Jan 9, 2024
@moogacs moogacs force-pushed the feature/backup_compression_server_endpoint branch 3 times, most recently from 6d3986c to 753e865 Compare January 9, 2024 14:27
@moogacs moogacs force-pushed the feature/backup_compression_server_endpoint branch from 753e865 to d3851de Compare January 9, 2024 18:36
@moogacs moogacs force-pushed the feature/backup_compression_server_endpoint branch from d3851de to 44735bd Compare January 9, 2024 18:48
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code

See analysis details on SonarCloud

@moogacs moogacs merged commit 07ff7ce into master Jan 10, 2024
22 checks passed
@moogacs moogacs deleted the feature/backup_compression_server_endpoint branch January 10, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moogacs moogacs moogacs left review comments

@parkerduckworth parkerduckworth parkerduckworth left review comments

@reyreaud-l reyreaud-l reyreaud-l approved these changes

@aliszka aliszka aliszka left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@redouan-rhazouani @aliszka @moogacs @reyreaud-l @parkerduckworth