Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring compressor #3880

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Refactoring compressor #3880

merged 3 commits into from
Dec 12, 2023

Conversation

abdelr
Copy link
Contributor

@abdelr abdelr commented Dec 11, 2023

What's being changed:

Rafactoring compressor

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@abdelr abdelr self-assigned this Dec 11, 2023
aliszka
aliszka reviewed Dec 12, 2023
View reviewed changes
adapters/repos/db/vector/testinghelpers/helpers.go Outdated
@@ -27,8 +27,8 @@ import (
"github.com/sirupsen/logrus/hooks/test"
"github.com/stretchr/testify/require"
"github.com/weaviate/weaviate/adapters/repos/db/lsmkv"
compressionhelpers "github.com/weaviate/weaviate/adapters/repos/db/vector/compressionhelpers"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alias is not needed here

adapters/repos/db/vector/hnsw/search.go Outdated
@@ -20,9 +20,9 @@ import (
"github.com/pkg/errors"
"github.com/weaviate/weaviate/adapters/repos/db/helpers"
"github.com/weaviate/weaviate/adapters/repos/db/priorityqueue"
compressionhelpers "github.com/weaviate/weaviate/adapters/repos/db/vector/compressionhelpers"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alias not needed

adapters/repos/db/vector/hnsw/neighbor_connections.go Outdated
@@ -18,11 +18,11 @@ import (
"github.com/pkg/errors"
"github.com/weaviate/weaviate/adapters/repos/db/helpers"
"github.com/weaviate/weaviate/adapters/repos/db/priorityqueue"
ssdhelpers "github.com/weaviate/weaviate/adapters/repos/db/vector/ssdhelpers"
compressionhelpers "github.com/weaviate/weaviate/adapters/repos/db/vector/compressionhelpers"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alias not needed

adapters/repos/db/vector/hnsw/insert.go Outdated
@@ -19,7 +19,7 @@ import (

"github.com/pkg/errors"
"github.com/weaviate/weaviate/adapters/repos/db/helpers"
ssdhelpers "github.com/weaviate/weaviate/adapters/repos/db/vector/ssdhelpers"
compressionhelpers "github.com/weaviate/weaviate/adapters/repos/db/vector/compressionhelpers"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alias not needed

adapters/repos/db/vector/hnsw/deserializer.go Outdated
@@ -20,7 +20,7 @@ import (
"github.com/pkg/errors"
"github.com/sirupsen/logrus"
"github.com/weaviate/weaviate/adapters/repos/db/vector/cache"
ssdhelpers "github.com/weaviate/weaviate/adapters/repos/db/vector/ssdhelpers"
compressionhelpers "github.com/weaviate/weaviate/adapters/repos/db/vector/compressionhelpers"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alias not needed

adapters/repos/db/vector/hnsw/commit_logger.go Outdated
@@ -24,8 +24,8 @@ import (

"github.com/pkg/errors"
"github.com/sirupsen/logrus"
compressionhelpers "github.com/weaviate/weaviate/adapters/repos/db/vector/compressionhelpers"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alias not needed

adapters/repos/db/vector/hnsw/benchmark_test.go Outdated
@@ -26,7 +26,7 @@ import (

"github.com/pkg/errors"
"github.com/stretchr/testify/require"
ssdhelpers "github.com/weaviate/weaviate/adapters/repos/db/vector/ssdhelpers"
compressionhelpers "github.com/weaviate/weaviate/adapters/repos/db/vector/compressionhelpers"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alias not needed

adapters/repos/db/vector/compressionhelpers/tile_encoder_test.go Outdated

import (
"math"
"math/rand"
"testing"

"github.com/stretchr/testify/assert"
ssdhelpers "github.com/weaviate/weaviate/adapters/repos/db/vector/ssdhelpers"
compressionhelpers "github.com/weaviate/weaviate/adapters/repos/db/vector/compressionhelpers"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alias not needed

adapters/repos/db/vector/compressionhelpers/product_quantization_test.go Outdated

import (
"fmt"
"sort"
"testing"

"github.com/stretchr/testify/assert"
compressionhelpers "github.com/weaviate/weaviate/adapters/repos/db/vector/compressionhelpers"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alias not needed

adapters/repos/db/vector/compressionhelpers/kmeans_test.go Outdated

import (
"testing"
"time"

"github.com/stretchr/testify/assert"
compressionhelpers "github.com/weaviate/weaviate/adapters/repos/db/vector/compressionhelpers"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alias not needed

@abdelr abdelr merged commit 9f5e522 into HNSW_BQ Dec 12, 2023
12 of 14 checks passed
@abdelr abdelr deleted the refactoring_compressor branch December 12, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliszka aliszka aliszka left review comments

Assignees

@abdelr abdelr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abdelr @aliszka