Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic backoff timer to limit any behavior, currently log messages #3912

Merged
merged 4 commits into from
Jan 3, 2024

Conversation

parkerduckworth
Copy link
Member

@parkerduckworth parkerduckworth commented Dec 16, 2023

What's being changed:

Abstracted from resource scans, generalized, and improved. Also applied to flush cycle readonly warning, since 1 log per second, per bucket are a lot of messages.

The constructor takes variadic arg of time.Duration, sorts it, and each iteration of interval-increase will take the next duration. Once the duration slice is exhausted, an interval of the longest duration is used for the remaining lifetime of the timer.

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

reyreaud-l
reyreaud-l previously approved these changes Dec 20, 2023
Copy link
Contributor

@reyreaud-l reyreaud-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM :)

entities/interval/backoff.go Outdated Show resolved Hide resolved
entities/interval/backoff.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Dec 28, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@parkerduckworth parkerduckworth merged commit 08b3bb1 into master Jan 3, 2024
23 checks passed
@parkerduckworth parkerduckworth deleted the feature/backoff-timer branch January 3, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants