Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration of compression tests to acceptance package #3923

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Migration of compression tests to acceptance package #3923

merged 5 commits into from
Jan 8, 2024
+1,146 −708

Conversation

aliszka
Copy link
Member

@aliszka aliszka commented Dec 18, 2023

What's being changed:

moves compression tests from integration ones to acceptance

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@aliszka aliszka changed the base branch from master to stable/v1.23 December 18, 2023 13:42
abdelr
abdelr previously approved these changes Dec 18, 2023
View reviewed changes
@aliszka aliszka changed the title Compression tests migration from integration to acceptance Migration of compression tests to acceptance package Dec 18, 2023
@aliszka aliszka requested a review from a team as a code owner December 18, 2023 23:47
@aliszka aliszka force-pushed the compressed_tests branch 3 times, most recently from d3a3c16 to bfc366c Compare December 20, 2023 11:28
@aliszka aliszka changed the base branch from stable/v1.23 to master December 20, 2023 11:28
@abdelr abdelr self-requested a review December 20, 2023 16:14
abdelr
abdelr previously approved these changes Dec 20, 2023
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

24.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@abdelr abdelr self-requested a review January 8, 2024 14:20
@aliszka aliszka merged commit c6150d4 into master Jan 8, 2024
21 of 22 checks passed
@aliszka aliszka deleted the compressed_tests branch January 8, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdelr abdelr abdelr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aliszka @abdelr