Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests and gha: speed acceptance tests and gha by modularizing the running test and parallelize them #4017

Merged
merged 12 commits into from
Jan 19, 2024
Merged

tests and gha: speed acceptance tests and gha by modularizing the running test and parallelize them #4017

merged 12 commits into from
Jan 19, 2024

Conversation

moogacs
Copy link
Contributor

@moogacs moogacs commented Jan 15, 2024 •
edited

What's being changed:

  • get benefits of reusuing containers to speed up acceptance tests
  • add test README.md
  • adjust gha wf to modularize the acceptances tests to run in parallel, so that acceptance tests runs in 5~6m instead of 15m overall.

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@weaviate-git-bot
Copy link

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@dirkkul
Copy link
Contributor

dirkkul commented Jan 16, 2024

If possible, could this target the stable branch? Then we get also get any improvements there :)

@moogacs
Copy link
Contributor Author

moogacs commented Jan 16, 2024

sure thing, it's still WIP I am trying to parallelize the testcontainers

@moogacs moogacs force-pushed the poc/acceptance/reuse branch 3 times, most recently from 89e150a to d6c7458 Compare January 17, 2024 16:24
@moogacs moogacs marked this pull request as ready for review January 17, 2024 17:47
@moogacs moogacs requested a review from a team as a code owner January 17, 2024 17:47
@moogacs moogacs changed the title test: enable reusing flag for testcontainers to speed up acceptance tests tests and gha: speed acceptance tests and gha by modularizing the running test and parallelize them Jan 17, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

30.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@moogacs moogacs merged commit 943f167 into master Jan 19, 2024
32 of 33 checks passed
@moogacs moogacs deleted the poc/acceptance/reuse branch January 19, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyreaud-l reyreaud-l reyreaud-l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@moogacs @weaviate-git-bot @dirkkul @reyreaud-l