New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use remainder to ensure last batch is indexed #4063

Merged

parkerduckworth merged 1 commit into master from bug/remainer-bm25bench

Jan 23, 2024

Contributor

amourao commented Jan 23, 2024

What's being changed:

Fix typo that made last batch not indexed for datasets when DOC_COUNT % BATCH_SIZE != 0

Review checklist

Documentation has been updated, if necessary. Link to changed documentation:
Chaos pipeline run or not necessary. Link to pipeline:
All new code is covered by tests where it is reasonable.
Performance tests have been run or not necessary.


          Use remainder to ensure last batch is indexed

ab7fb91

sonarcloud bot commented Jan 23, 2024

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

parkerduckworth approved these changes

View reviewed changes

Member

parkerduckworth left a comment

Nice catch 🙂

parkerduckworth merged commit 1ca650c into master

35 checks passed

parkerduckworth deleted the bug/remainer-bm25bench branch

January 23, 2024 17:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment