Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better BM25 benchmarking #4078

Merged
merged 7 commits into from
Feb 14, 2024
Merged

Better BM25 benchmarking #4078

merged 7 commits into from
Feb 14, 2024

Conversation

amourao
Copy link
Contributor

@amourao amourao commented Jan 25, 2024

What's being changed:

  • Test multiple datasets at once
  • Better logging
  • "Machine readable" logging after all experiments are run
  • optional, "query as you import" mode for scalability tests

This is a potential "breaking" change, as it runs all datasets in the yaml file, which may not be the intended behavior in the places where the benchmark is being used.

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@amourao amourao marked this pull request as ready for review February 7, 2024 13:32
Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jeroiraz jeroiraz self-requested a review February 14, 2024 16:01
@amourao amourao merged commit a63eb71 into master Feb 14, 2024
32 of 33 checks passed
@amourao amourao deleted the better-bm25-benchmark branch February 14, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants