Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal telemetry in OSS Weaviate #4097

Merged
merged 13 commits into from
Feb 14, 2024
Merged

Minimal telemetry in OSS Weaviate #4097

merged 13 commits into from
Feb 14, 2024

Conversation

parkerduckworth
Copy link
Member

@parkerduckworth parkerduckworth commented Jan 29, 2024

What's being changed:

This PR addresses issue #3495, and introduces telemetry into Weaviate.

Highlights

  • Telemetry is enabled by default, can opt-out with DISABLE_TELEMETRY=true
  • The following information is transmitted:
    • unique machine id generated on instance startup
    • type of telemetry payload (INIT|UPDATE|TERMINATE)
    • instance server version
    • which modules are enabled
    • number of objects in the instance
    • the OS/Arch of the machine backing the instance

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

Copy link
Contributor

@moogacs moogacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really Good, just left minor improvements, I am excited about that change 👍🏼

Copy link
Contributor

@daveatweaviate daveatweaviate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @parkerduckworth - looking forward to seeing how this works in the wild

usecases/config/config_handler.go Outdated Show resolved Hide resolved
usecases/telemetry/telemetry.go Show resolved Hide resolved
Copy link
Contributor

@moogacs moogacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to confirm the license with that change and change the text url to encoded one

usecases/telemetry/telemetry.go Show resolved Hide resolved
usecases/telemetry/telemetry.go Outdated Show resolved Hide resolved
usecases/telemetry/telemetry.go Show resolved Hide resolved
adapters/handlers/rest/configure_api.go Outdated Show resolved Hide resolved
@parkerduckworth
Copy link
Member Author

we need to confirm the license with that change and change the text url to encoded one

@moogacs I have cleared the license issue with responsible team. Encoded url change found here

moogacs
moogacs previously approved these changes Feb 13, 2024
Copy link
Contributor

@moogacs moogacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 , just left 1 suggestion

usecases/telemetry/telemetry.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants