-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal telemetry in OSS Weaviate #4097
Conversation
Great to see you again! Thanks for the contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really Good, just left minor improvements, I am excited about that change 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @parkerduckworth - looking forward to seeing how this works in the wild
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to confirm the license with that change and change the text url to encoded one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 , just left 1 suggestion
|
What's being changed:
This PR addresses issue #3495, and introduces telemetry into Weaviate.
Highlights
DISABLE_TELEMETRY=true
INIT
|UPDATE
|TERMINATE
)Review checklist