Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle internal errors in BM25/WAND logic more gracefully #4100

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Handle internal errors in BM25/WAND logic more gracefully #4100

merged 2 commits into from
Jan 30, 2024

Conversation

etiennedi
Copy link
Member

What's being changed:

  • catches panic
  • returns generic error to the user
  • prints original panic annotated with shard/class name in logs
Screenshot 2024-01-30 at 9 33 34 AM Screenshot 2024-01-30 at 9 35 32 AM

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

aliszka
aliszka previously approved these changes Jan 30, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@etiennedi etiennedi merged commit 86488e5 into stable/v1.23 Jan 30, 2024
22 of 23 checks passed
@etiennedi etiennedi deleted the bm25-panic-handling branch January 30, 2024 09:28
@etiennedi etiennedi restored the bm25-panic-handling branch January 30, 2024 09:28
@etiennedi etiennedi deleted the bm25-panic-handling branch January 30, 2024 09:28
@etiennedi etiennedi mentioned this pull request Feb 4, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliszka aliszka aliszka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etiennedi @aliszka