Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting default values for weaviate server #4106

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

avirlrma
Copy link
Contributor

@avirlrma avirlrma commented Jan 30, 2024

partly fixes #2656

Changes

  1. Setting default value for PERSISTENCE_DATA_PATH to ./data if not set in config and as env var.
  2. Setting default value for AUTHENTICATION to Anonymous access enabled = true if not set in config and as env var.
  3. Setting default value for QUERY_DEFAULTS_LIMIT to 10 if not set in config and as env var.
  4. Add unit tests for these^.

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@weaviate-git-bot
Copy link

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

set default values for:
- PERSISTENCE_DATA_PATH
- AUTHENTICATION_ANONYMOUS_ACCESS_ENABLED
- QUERY_DEFAULTS_LIMIT
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

15.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@reyreaud-l reyreaud-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approved the CI tests run. Waiting to see their results.

@etiennedi
Copy link
Member

Hey @avirlrma,

Thank you very much for your contribution. This should surely make it much easier to run Weaviate without any parameters!

Could you indicate (through a comment) that you accept the CLA? (See 🤖 comment above). Then we can merge.

@avirlrma
Copy link
Contributor Author

avirlrma commented Feb 1, 2024

I agree with the CLA.

@avirlrma
Copy link
Contributor Author

avirlrma commented Feb 1, 2024

Thanks for the review @reyreaud-l !

@parkerduckworth
Copy link
Member

Thanks for the contribution @avirlrma!

@parkerduckworth parkerduckworth merged commit b91d3c3 into weaviate:master Feb 1, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UX] Weaviate should be runnable without any env vars or cli args set
5 participants