-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting default values for weaviate server #4106
Conversation
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
set default values for: - PERSISTENCE_DATA_PATH - AUTHENTICATION_ANONYMOUS_ACCESS_ENABLED - QUERY_DEFAULTS_LIMIT
Quality Gate failedFailed conditions 15.9% Duplication on New Code (required ≤ 3%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Approved the CI tests run. Waiting to see their results.
Hey @avirlrma, Thank you very much for your contribution. This should surely make it much easier to run Weaviate without any parameters! Could you indicate (through a comment) that you accept the CLA? (See 🤖 comment above). Then we can merge. |
I agree with the CLA. |
Thanks for the review @reyreaud-l ! |
Thanks for the contribution @avirlrma! |
partly fixes #2656
Changes
PERSISTENCE_DATA_PATH
to./data
if not set in config and as env var.AUTHENTICATION
toAnonymous access enabled = true
if not set in config and as env var.QUERY_DEFAULTS_LIMIT
to10
if not set in config and as env var.Review checklist