Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for baseURL in generative-openai azure config #4124

Merged

Conversation

antas-marcin
Copy link
Contributor

@antas-marcin antas-marcin commented Feb 2, 2024

What's being changed:

This PR adds the ability to define baseURL when user uses Azure (closes #4092).

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@antas-marcin antas-marcin force-pushed the add-support-for-baseurl-in-generative-openai branch from e336349 to ecbe179 Compare February 6, 2024 17:02
@antas-marcin antas-marcin force-pushed the add-support-for-baseurl-in-generative-openai branch from ecbe179 to d5f2cba Compare February 6, 2024 17:04
Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

31.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants