-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent segment inconsistencies #4129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16ea4e9
to
99670a0
Compare
f8a9c84
to
3ac5941
Compare
60013ec
to
a219028
Compare
amourao
reviewed
Feb 9, 2024
amourao
reviewed
Feb 9, 2024
amourao
reviewed
Feb 9, 2024
amourao
reviewed
Feb 9, 2024
amourao
reviewed
Feb 9, 2024
9055471
to
210e862
Compare
LGTM, but I am going to run this through the chaos pipeline now, before we merge this. Also @amourao are you ok with all the explanations in your unresolved threads? |
210e862
to
f91121d
Compare
Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>
Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>
Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>
Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>
Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>
Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>
Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>
Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>
Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>
Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>
Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>
Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>
Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>
Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>
09c03c2
to
069a46f
Compare
|
parkerduckworth
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrity checking was added to WAL files in a backward compatible manner. The new WAL entries data format is defined as follows:
What's being changed:
Memtable serialization into a Segment file and Segment compaction process with stronger crash-tolerance
Review checklist