Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nil props to GRPC map #4135

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Add nil props to GRPC map #4135

merged 6 commits into from
Feb 5, 2024
+166 −93

Conversation

dirkkul
Copy link
Contributor

@dirkkul dirkkul commented Feb 5, 2024

What's being changed:

Adds nil as possible value to the grpc mapping

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@dirkkul dirkkul mentioned this pull request Feb 5, 2024
Closed
4 tasks
@dirkkul dirkkul changed the title Nil props grpc Add nil props to GRPC map Feb 5, 2024
tsmith023
tsmith023 previously approved these changes Feb 5, 2024
View reviewed changes
@dirkkul dirkkul requested a review from a team as a code owner February 5, 2024 11:06
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

13.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@tsmith023 tsmith023 merged commit faeecbd into master Feb 5, 2024
31 of 32 checks passed
@tsmith023 tsmith023 deleted the nil_props_grpc2 branch February 5, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmith023 tsmith023 tsmith023 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dirkkul @tsmith023