Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch Vectorizer #4147

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Batch Vectorizer #4147

merged 3 commits into from
Feb 6, 2024

Conversation

dirkkul
Copy link
Contributor

@dirkkul dirkkul commented Feb 6, 2024 •
edited

What's being changed:

Some initial cleanup:

  • removes an unused error return
  • removes .Vector from Batchobject and use .Object.vector instead

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

41.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@dirkkul dirkkul merged commit 8968160 into master Feb 6, 2024
32 of 33 checks passed
@dirkkul dirkkul deleted the vectorize_batch branch February 6, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antas-marcin antas-marcin antas-marcin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dirkkul @antas-marcin