Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locks: write-only sharded locks #4156

Merged
merged 3 commits into from
Feb 7, 2024
Merged

locks: write-only sharded locks #4156

merged 3 commits into from
Feb 7, 2024

Conversation

asdine
Copy link
Member

@asdine asdine commented Feb 7, 2024

What's being changed:

This adds a write-only (sync.Mutex) variant of the sharded locks for scenarios where only Lock/Unlock is needed and the lock performance is important.

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@asdine asdine changed the title Write only sharded locks dx: write-only sharded locks Feb 7, 2024
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

22.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@asdine asdine changed the title dx: write-only sharded locks locks: write-only sharded locks Feb 7, 2024
@asdine asdine requested review from abdelr and aliszka February 7, 2024 10:44
@asdine asdine merged commit 8a9d5a4 into master Feb 7, 2024
32 of 33 checks passed
@asdine asdine deleted the write-only-sharded-locks branch February 7, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants