Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include dictionary files in docker image, add test #4158

Merged
merged 26 commits into from
Feb 13, 2024
Merged

Include dictionary files in docker image, add test #4158

merged 26 commits into from
Feb 13, 2024

Conversation

donomii
Copy link
Contributor

@donomii donomii commented Feb 7, 2024

What's being changed:

Include the necessary dictionary files in the final image

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@donomii donomii self-assigned this Feb 7, 2024
amourao
amourao reviewed Feb 7, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@donomii donomii marked this pull request as ready for review February 7, 2024 13:08
amourao
amourao previously approved these changes Feb 7, 2024
View reviewed changes
aliszka
aliszka previously approved these changes Feb 12, 2024
View reviewed changes
amourao
amourao previously approved these changes Feb 13, 2024
View reviewed changes
amourao
amourao previously approved these changes Feb 13, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@donomii donomii requested a review from amourao February 13, 2024 11:07
amourao
amourao approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@amourao amourao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donomii donomii merged commit 18132db into master Feb 13, 2024
32 of 33 checks passed
@donomii donomii deleted the dictionary-files branch February 13, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amourao amourao amourao approved these changes

@aliszka aliszka aliszka left review comments

Assignees

@donomii donomii

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@donomii @aliszka @amourao