Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HNSW BQ dimension tracking #4209

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

trengrj
Copy link
Member

@trengrj trengrj commented Feb 14, 2024

What's being changed:

With the newly introduced HNSW BQ feature we also need metrics which are used for billing / sizing to reflect this.

  • HNSW BQ will cause an 8x reduction to vector_segments_dimensions
  • DimensionCategory type created for easier extension in the future
  • Additional tests were added that directly inspect prometheus metrics
  • Typo fixed for resetting PQ vector_segments_dimensions when a class is deleted

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
59.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@trengrj trengrj requested a review from aliszka February 14, 2024 09:36
@aliszka aliszka merged commit 2d81b71 into master Feb 14, 2024
31 of 33 checks passed
@aliszka aliszka deleted the trengrj/hnsw-bq-dimension-tracking branch February 14, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants